Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only refresh current trending tab #6667

Conversation

ChunkyProgrammer
Copy link
Member

@ChunkyProgrammer ChunkyProgrammer commented Jan 30, 2025

Only refresh current trending tab

Pull Request Type

  • Feature Implementation

Related issue

closes #6420

Description

Refreshing trending tab will now only refresh the current tab

Testing

  • go to trending page
  • navigate to each tab
  • refresh on a tab
  • go to another tab
  • notice it's not loading on that tab since the data is cached

Desktop

  • OS: Fedora Linux
  • OS Version: 41 KDE
  • FreeTube version: latest nightly

Additional context

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) January 30, 2025 17:55
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Jan 30, 2025
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refresh status has disappeared

VirtualBoxVM_W1uQyK7nTb.mp4

@absidue
Copy link
Member

absidue commented Jan 30, 2025

I'm going to change the pull request type for this pull request and the icons next to titles ones, as they are both feature implementations.

@FreeTubeBot FreeTubeBot merged commit ffdd1ec into FreeTubeApp:development Jan 30, 2025
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Jan 30, 2025
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request Feb 1, 2025
* development:
  Translated using Weblate (Indonesian)
  Bump version number to v0.23.1
  Translated using Weblate (Portuguese (Brazil))
  Fix comment sorting when sort by newest is the default (FreeTubeApp#6702)
  ! Fix license data reading code causing some videos cannot be played (FreeTubeApp#6682)
  Translated using Weblate (Spanish)
  Update release.yml
  Update release.yml
  Bump version number to v0.23.0
  Add Creative Commons License to Description of Videos (FreeTubeApp#6614)
  Only refresh current trending tab (FreeTubeApp#6667)
  Translated using Weblate (Icelandic)
  Translated using Weblate (Chinese (Traditional Han script))
  Translated using Weblate (Arabic)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Dont refresh all Trending tabs if one tab received refresh
5 participants