Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Subscriptions and SubscriptionsTabUi to the composition API #6612

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

Migrate Subscriptions and SubscriptionsTabUi to the composition API #6612

wants to merge 1 commit into from

Conversation

absidue
Copy link
Member

@absidue absidue commented Jan 20, 2025

Migrate Subscriptions and SubscriptionsTabUi to the composition API

Pull Request Type

  • Refactoring - Composition API migration

Description

This pull request migrates the Subscriptions and SubscriptionsTabUi components to the composition API. The subscriptions-{videos,shorts,live,community} components will be migrated in a separate pull request so that we don't have one large, difficult to review pull request.

Testing

  1. Check that the subscriptions page and tabs show up.
  2. Test the "Hide Subscriptions {Videos,Shorts,Live,Community}" settings.
  3. Check that refreshing works.
  4. Check that "loading more" (increasing the amount of displayed items) works.

Desktop

  • OS: Windows
  • OS Version: 10
  • FreeTube version: d35174e

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Jan 20, 2025
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) January 20, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc approved these changes

@PikachuEXE PikachuEXE PikachuEXE approved these changes

@ChunkyProgrammer ChunkyProgrammer Awaiting requested review from ChunkyProgrammer

@kommunarr kommunarr Awaiting requested review from kommunarr

@MarmadileManteater MarmadileManteater Awaiting requested review from MarmadileManteater

At least 3 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
PR: waiting for review For PRs that are complete, tested, and ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@absidue @PikachuEXE @efb4f5ff-1298-471a-8973-3d47447115dc