Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump electron from 33.3.1 to 34.0.0 #6608

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 20, 2025

Bumps electron from 33.3.1 to 34.0.0.

Release notes

Sourced from electron's releases.

electron v34.0.0

Release Notes for v34.0.0

Stack Upgrades

Breaking Changes

  • Made menu bar hidden on fullscreen in Windows. #43402

Features

Additions

  • Added APIs to manage shared dictionaries for compression efficiency using Brotli or ZStandard. The new APIs are session.getSharedDictionaryUsageInfo(), session.getSharedDictionaryInfo(options), session.clearSharedDictionaryCache(), and session.clearSharedDictionaryCacheForIsolationKey(options). #44950 (Also in 33)
  • Added WebFrameMain.collectJavaScriptCallStack() for accessing the JavaScript call stack of unresponsive renderers. #44938 (Also in 33)
  • Added WebFrameMain.detached for frames in an unloading state.
    • Added WebFrameMain.isDestroyed() to determine if a frame has been destroyed.
    • Fixed webFrameMain.fromId(processId, frameId) returning a WebFrameMain instance which doesn't match the given parameters when the frame is unloading. #43473 (Also in 33)
  • Added error event in utility process to support diagnostic reports on V8 fatal errors. #43774 (Also in 33)
  • Added support for the macOS system picker in desktopCapturer and setDisplayMediaRequestHandler. #43581 (Also in 32, 33)
  • Feat: GPU accelerated shared texture offscreen rendering. #42953 (Also in 33)

Improvements

  • Performance improvements when processing microtasks. #44471 (Also in 32, 33)

Fixes

  • Fixed file chooser dialogs for flaptak applications. #44681
  • Fixed issue where 'contextmenu' event is emitted twice on macOS. #44997

Also in earlier versions...

  • Fixed BrowserView auto resize issue. #43463 (Also in 31, 32, 33)
  • Fixed MenuItem.click handler not setting focusedWindow parameter when focused window is a BaseWindow. #43404 (Also in 31, 32, 33)
  • Fixed chrome.i18n extension API being unavailable in service workers. #45036 (Also in 31, 32, 33)
  • Fixed trace-startup not working on macOS. #44275 (Also in 32, 33)
  • Fixed a build failure when the enable_plugins build flag is false. #44003 (Also in 33)
  • Fixed a crash that could occur when calling shell.readShortcutLink on Windows. #44804 (Also in 33)
  • Fixed a crash when calling focus on a WebView's webContents. #43921 (Also in 31, 32, 33)
  • Fixed a potential issue accessing a child window document when overriding browserWindow creation via setWindowOpenHandler. #43775 (Also in 31, 32, 33)
  • Fixed a potential issue with fillable PDF forms saving correctly in some circumstances. #43667 (Also in 31, 32, 33)
  • Fixed an issue when dragging to resize when using Window Controls Overlay on Linux. #43724 (Also in 31, 32, 33)
  • Fixed an issue where BaseWindow.setTouchBar didn't work as expected. #43353 (Also in 30, 31, 32, 33)
  • Fixed an issue where EventSource was undefined in both renderer and worker processes when Node.js integration was enabled. #44495 (Also in 32, 33)
  • Fixed an issue where WebContentsViews did not show correctly in some circumstances on macOS after being added as child views. #43638 (Also in 31, 32, 33)
  • Fixed an issue where WebContentsViews were being improperly removed. #44670 (Also in 31, 32, 33)

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added PR: dependencies Pull requests that update a dependency file PR: waiting for review For PRs that are complete, tested, and ready for review labels Jan 20, 2025
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) January 20, 2025 08:15
Copy link
Collaborator

@PikachuEXE PikachuEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only breaking change: Made menu bar hidden on fullscreen in Windows.

@efb4f5ff-1298-471a-8973-3d47447115dc

Cant confirm because I'm on mobile but it looks like the breaking changes doesn't affect us

Bumps [electron](https://github.com/electron/electron) from 33.3.1 to 34.0.0.
- [Release notes](https://github.com/electron/electron/releases)
- [Changelog](https://github.com/electron/electron/blob/main/docs/breaking-changes.md)
- [Commits](electron/electron@v33.3.1...v34.0.0)

---
updated-dependencies:
- dependency-name: electron
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/electron-34.0.0 branch from 80c97ec to 542ac2f Compare January 20, 2025 12:41
@FreeTubeBot FreeTubeBot merged commit db5b166 into development Jan 20, 2025
6 checks passed
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/electron-34.0.0 branch January 20, 2025 13:46
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Jan 20, 2025
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request Jan 21, 2025
* development: (23 commits)
  Translated using Weblate (Czech)
  Translated using Weblate (German)
  Translated using Weblate (Basque)
  Translated using Weblate (Ukrainian)
  Translated using Weblate (German)
  Translated using Weblate (Basque)
  Translated using Weblate (German)
  Stay in fullscreen/fullwindow/PiP + default viewing mode setting (FreeTubeApp#5903)
  Undo Feature For Remove From Playlist. (FreeTubeApp#5885)
  group builds (FreeTubeApp#6497)
  Change CREATE_NEW_WINDOW IPC call to accept a path and query (FreeTubeApp#6595)
  Bump shaka-player from 4.12.7 to 4.12.8 (FreeTubeApp#6609)
  Bump electron from 33.3.1 to 34.0.0 (FreeTubeApp#6608)
  Translated using Weblate (French)
  Bump sass from 1.83.1 to 1.83.4 (FreeTubeApp#6607)
  Bump lefthook from 1.10.3 to 1.10.9 (FreeTubeApp#6606)
  Bump eslint-plugin-jsdoc from 50.6.1 to 50.6.2 in the eslint group (FreeTubeApp#6604)
  Translated using Weblate (Czech)
  Translated using Weblate (Estonian)
  Translated using Weblate (German)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants