Use Date.now() and Date.parse() when a millisecond value is needed

[absidue]

Use Date.now() and Date.parse() when a millisecond value is needed

Pull Request Type

• Performance improvement

Description

At the moment when we need to parse a date but get the millisecond value from it we call the Date() constructor and then call .getTime() on it, in this pull request we instead use Date.parse() which uses the same string date parsing algorithm as the Date() constructor but directly produces a number of milliseconds. I also fixed another instance of using the Date() constructor without any arguments and then calling .getTime() on it, which wasn't caught by the linter (presumably because it was split up and .getTime() was called multiple times).

Testing

1. Refresh your subscriptions with RSS enabled and check that the published dates show up.
2. Visit any page that has lists of videos with the local API and check that the published dates show up (e.g. search, trending, channel pages).
3. Open a video and check that the published date shows up in the video info section.

Desktop

• OS: Windows
• OS Version: 10
• FreeTube version: d4ad95b