Reduce repeated code in secondary theme colours #6505
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer,
kommunarr and
MarmadileManteater
and removed request for
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer,
kommunarr and
MarmadileManteater
|
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
efb4f5ff-1298-471a-8973-3d47447115dc
added
PR: WIP
PR/Issue: dependent
and removed
PR: stale
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce repeated code in secondary theme colours
Pull Request Type
Related issue
Description
For each secondary theme colour we specify 5 variables
--accent-colorand--accent-color-opacity{1,2,3,4}, where the opacity ones are just the--accent-colorwith various levels of opacity. At the moment that is done in the classes of the secondary theme colours. This pull request instead specifies just a single variable--accent-color-rgbin each class and then uses that in the body rule to construct the 5 variables withrgb().This reduces the amount of work for people adding new themes and also shaves about 10kb (10333 bytes) off the output CSS file compared to the development branch.
Testing
Test a few theme colours to check they still work and that the Hot Pink theme is still able to override them.
Desktop