Improve audio quality by selecting highest audio bitrate

[AlyoshaVasilieva]

Improve audio quality by selecting stream with highest audio bitrate

Pull Request Type

• Bugfix

Related issue

#6138

Description

Select the stream with the highest audio bitrate. Improves the issue where FreeTube usually uses the lowest quality audio available, but does not fix it. This patch seems to work as long as you do not select a quality while watching a video. Selecting a quality (e.g. 1080p) specifically while watching a video will usually give you bad audio. See #6138 for more info. I don't know how to fix this issue in the general case, but at least this improves things.

Testing

Try watching videos with/without this patch, e.g. https://youtu.be/G4qVG_FL4_s

Desktop

• OS: Windows
• OS Version: 10
• FreeTube version: 0.22.1 (1c3728e + this patch)

[absidue]

Accepting this as a temporary workaround until a proper solution is implemented. Worth noting that this increases bandwidth use and will slow down video loading.

[PikachuEXE]

Quality selector display broken

Using commit before this PR

[AlyoshaVasilieva]

I don't know how to fix the quality selector display

[absidue]

@PikachuEXE @AlyoshaVasilieva The quality selector being broken is expected, shaka-player quality selector chooses the first variants in the array, but as we are now intentionally selecting something else, the quality selector doesn't know what to show. The solutions are don't merge this PR or build an entirely custom quality selector that knows how to cope with our non-standard behaviour. The latter is definitely out of scope of this pull request.

[PikachuEXE]

Even though I might be fine with using this personally
I think it would appears broken to normal users unaware of this workaround and would report it as an issue
This should not be included in a release IMO

[github-actions]

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

[absidue]

You can leave as many comments as you want, but it won't change the fact that this is currently on hold until a solution is found for the quality selector. Fixing one thing just to break something else in the process is not great.

[PietJanHein]

You can leave as many comments as you want, but it won't change the fact that this is currently on hold until a solution is found for the quality selector. Fixing one thing just to break something else in the process is not great.

That is understandable, It is not my intention to put extra pressure on the developers, I just wanted to make clear that more people would like it if that would/could get fixed. Until then FreeTube also is nice to get the videolinks and then we can simply play it in mpv.

[PikachuEXE]

Please use reaction to "vote" / express your support for this change
Devs are all getting notifications for each new comment.
Unless you have helpful info to push this forward (towards merge / close) attention consuming comments should be restrained.