Prevent typing in 'input' from triggering keyboard shortcut modal open #6501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: waiting for review
kommunarr
requested review from
PikachuEXE,
absidue,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer and
MarmadileManteater
efb4f5ff-1298-471a-8973-3d47447115dc
previously approved these changes
Jan 2, 2025
PikachuEXE
reviewed
Jan 3, 2025
kommunarr
force-pushed
the
fix/shortcut-modal-while-typing-in-input
branch
from
c1fdef2 to
a7d65a9
Compare
kommunarr
requested review from
efb4f5ff-1298-471a-8973-3d47447115dc and
PikachuEXE
PikachuEXE
approved these changes
Jan 3, 2025
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Jan 3, 2025
absidue
approved these changes
Jan 3, 2025
github-actions
bot
removed
the
PR: waiting for review
SuperAKWA
pushed a commit
to SuperAKWA/FreeTube
that referenced
this pull request
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent typing in 'input' from triggering keyboard shortcut modal open
Pull Request Type
Related issue
closes #6500
Description
Prevents user inputting a question mark in an HTML
inputfrom triggering the keyboard shortcut modal.Testing
?in any input and see shortcut modal not open?outside any input and see shortcut modal openDesktop