Deduplicate "Sort By" strings into a single "Global.Sort By" string #6495
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deduplicate "Sort By" strings into a single "Global.Sort By" string
Pull Request Type
Description
We currently have five "Sort By" strings in FreeTube, they are all used for the same purpose: the label for a select box with sort orders for lists. This pull request deduplicates them into a single string in the
Global
namespace.For locales where the same string was used, I just used that one, but some locales had different translations, so for those I picked the most recently updated one according to git blame.
The reasons for such a change are as follows:
Testing
Test a few locales and check that the sort by text shows up correctly.
Desktop