Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate "Sort By" strings into a single "Global.Sort By" string #6495

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

absidue
Copy link
Member

@absidue absidue commented Jan 1, 2025

Deduplicate "Sort By" strings into a single "Global.Sort By" string

Pull Request Type

  • Other

Description

We currently have five "Sort By" strings in FreeTube, they are all used for the same purpose: the label for a select box with sort orders for lists. This pull request deduplicates them into a single string in the Global namespace.

For locales where the same string was used, I just used that one, but some locales had different translations, so for those I picked the most recently updated one according to git blame.

The reasons for such a change are as follows:

  • As these strings all have the same meaning and use, it makes sense to use the same one throughout the app.
  • For languages that might not have all 5 of them translated yet, this pull request will result in more parts of the app being translated without the translators having to do anything.
  • Less strings means less work for translators, especially when it is duplicates like these.

Testing

Test a few locales and check that the sort by text shows up correctly.

Desktop

  • OS: Windows
  • OS Version: 10
  • FreeTube version: 367781a

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Jan 1, 2025
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) January 1, 2025 23:31
@absidue absidue mentioned this pull request Jan 1, 2025
4 tasks
Copy link
Collaborator

@PikachuEXE PikachuEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested en/jp/zh-TW

@FreeTubeBot FreeTubeBot merged commit 1c3728e into FreeTubeApp:development Jan 2, 2025
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Jan 2, 2025
@absidue absidue deleted the sort-by-strings branch January 2, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants