Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect and properly error on DRM protected videos #6479

Merged
merged 2 commits into from
Dec 31, 2024

Conversation

absidue
Copy link
Member

@absidue absidue commented Dec 29, 2024

Detect and properly error on DRM protected videos

Pull Request Type

  • Bugfix

Related issue

Description

DRM protected videos cannot be played in FreeTube as that requires the proprietary, closed source Widevine CDM and a VMP signed build of Electron, both things which are understandably not included in the standard open source Electron builds. This pull request adds support for FreeTube to detect such videos and show a user friendly message (instead of it attempting and failing to play the DRM protected content).

Unfortunately the movie trailers are unlisted videos, so we can't just find the trailer some other way if it isn't included in the API response like they are for movies that are not free with ads.

Screenshots

screenshot-drm-message

Testing

  1. Find a free with ads movie (e.g. https://youtu.be/3fE5uTeBGUM in the US, provided in the linked issue)
  2. Visit the page on the local API, you should see the same message as in the screenshot

Desktop

  • OS: Windows
  • OS Version: 10
  • FreeTube version: c7c6dfd

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Dec 29, 2024
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) December 29, 2024 23:36
Copy link
Collaborator

@kommunarr kommunarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought (non-blocking, future): I'd like it if there were click-to-copy and/or open-in-browser links that appeared for these types of error popups where the appropriate action is often to open first-party.

@FreeTubeBot FreeTubeBot merged commit 6338e65 into FreeTubeApp:development Dec 31, 2024
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Dec 31, 2024
@absidue absidue deleted the detect-drm branch December 31, 2024 09:51
SuperAKWA pushed a commit to SuperAKWA/FreeTube that referenced this pull request Jan 24, 2025
* Detect and properly error on DRM protected videos

* Fix view count handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: YouTube Movies cannot be played
6 participants