Disable store strict mode, due to performance problems because of the amount of data in the store #6469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… amount of data in the store
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer,
kommunarr and
MarmadileManteater
github-actions
bot
added
the
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Dec 28, 2024
|
It hasn't bothered me so far, but I'm on board if it's meaningfully hampering anyone's testing |
PikachuEXE
approved these changes
Dec 29, 2024
kommunarr
approved these changes
Dec 29, 2024
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Dec 30, 2024
* development: (75 commits) Bump lefthook from 1.10.0 to 1.10.1 (FreeTubeApp#6480) Bump bgutils-js from 3.1.0 to 3.1.1 (FreeTubeApp#6482) Translated using Weblate (Estonian) Translated using Weblate (Serbian) Translated using Weblate (Polish) Translated using Weblate (Czech) Translated using Weblate (English (United Kingdom)) Translated using Weblate (Hungarian) Translated using Weblate (Hungarian) Translated using Weblate (German) Translated using Weblate (Italian) Translated using Weblate (French) Translated using Weblate (Chinese (Simplified Han script)) FtRadioButton and FtCheckboxList v-model and composition API (FreeTubeApp#6463) Disable store strict mode, due to performance problems because of the amount of data in the store (FreeTubeApp#6469) [Feature] Playlist: Sort videos by published date (FreeTubeApp#6280) Migrate ChannelAbout to the composition API (FreeTubeApp#6470) Translated using Weblate (German) compress frappe svgs (FreeTubeApp#6467) Translated using Weblate (Hungarian) ...
SuperAKWA
pushed a commit
to SuperAKWA/FreeTube
that referenced
this pull request
Jan 24, 2025
… amount of data in the store (FreeTubeApp#6469)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable store strict mode, due to performance problems because of the amount of data in the store
Pull Request Type
Related issue
#6414 (comment)
#6414 (comment)
Description
Vuex's strict mode is intended to warn you about modifications to the store state outside of mutations as those are unsafe and can cause problems with the changes not getting tracked and propagated properly. However as it works by adding a deep watcher to the store, the performance impact it has is directly connected to the amount of data in the store and the amount of reads and writes that you do, unfortunately we have reached a point where we have so much data in the store (and are planning to keep adding more, with it being unlikely that we will scale back (removing features anyone?)), that it causes noticable slow downs.
This pull request disables those safety checks in vuex to get the performance back to an acceptable level but we just need to be more careful when writing code that interacts with the store, as we won't get "automated" warnings anymore about unsafe code.
I also fixed the
grabAllProfilesaction accessing the state in the wrong way.Testing
yarn devDesktop