Update autoplay next recommended/playlist video setting to be "by default"

[PikachuEXE]

Pull Request Type

• Bugfix
• Feature Implementation
• Documentation
• Other

Related issue

Description

This PR does:

• Update behaviour of these settings
  • Autoplay Recommended Videos
  • Autoplay Playlist Videos
• Above settings now affect the video playing session's initial values only, where a "video playing session" is the period that user stays on the watch page (for N videos)
  • Changing the setting in settings page won't affect existing "video playing sessions" value
  • Changing the autoplay value in a "video playing session" won't affect global setting

Screenshots

Screen.Recording.2024-12-17.at.10.29.50.mp4

Testing

(A1) Autoplay Recommended Videos disabled by default

• Update auto play in settings to false
• Open 2 videos without playlist, confirm both got auto play disabled
• Update global setting to true, confirm both still got auto play disabled
• Update global setting to false, update one/both auto play to true, confirm global setting still false
• Pick 1 window (can test on all windows but not necessary), jump to next video, confirm local state unchanged (still true)
• Pick 1 window, get to any non watch page, get back, confirm local state set to global state

(A2)

• Steps of (A1) but value reversed

(B1) Autoplay Playlist Videos disabled by default

• Update auto play in settings to false
• Open 2 videoswith playlist, confirm both got auto play disabled
• Update global setting to true, confirm both still got auto play disabled
• Update global setting to false, update one/both auto play to true, confirm global setting still false
• Pick 1 window (can test on all windows but not necessary), jump to next video, confirm local state unchanged (still true)
• Pick 1 window, get to any non watch page, get back, confirm local state set to global state

(B2)

• Steps of (B1) but value reversed

Desktop

• OS:
• OS Version:
• FreeTube version:

Additional context

Existing settings which can be changed in watch page and acts default value

[kommunarr]

Ooh, I like it! I have three thoughts:

1. issue (minor, non-blocking): If we're doing it one way for recommended video autoplay, we should be doing it the same way for playlist autoplay as well, otherwise it's a bit jarring / confusing as a user to read. I get that that's done because playlist autoplay is currently not toggleable from the player page (until Add autoplay toggle to the video player #5866), but I'd recommend only merging this if we're confident we can get that other part included in the same release.
2. nitpick: Maybe we should colocate the autoplay buttons on the left side now so the "by Default"s are by one another.
3. nitpick: The "by Default" phrasing is reasonable to use here and consistent, but in general, I do think it makes our labels more verbose. Maybe in this or a separate PR we move all of these to its own sub-section of "Default Settings" or something like that?

[PikachuEXE]

Removed usage of sessionStore (stupid move + I am vue newbie?
I shouldn't use sessionStore for something only last for the the duration of Watch page

(1) see commit 2
(2) Not quite sure what you mean. Autoplay Videos probably isn't included, so playlist + recommended videos?
(3) Might need a separate PR, too many things to agree on and testing (makes this PR too complicated). We can discuss here but better be done after we did (1) and maybe (2) and other main changes first

About (1) I did not make any change to pause button due to #5866
But if that PR might take longer I can change the pause button to the toggle like Up Next

[efb4f5ff-1298-471a-8973-3d47447115dc]

@kommunarr i think that pika is waiting on you to respond to their latest message

[kommunarr]

(2) Not quite sure what you mean. Autoplay Videos probably isn't included, so playlist + recommended videos?

Yes, if we are to update the logic and names of both, all the "by Default"s should be in the same column. Although like I said in 3, I'm still not a fan of the "by Default" being there in our setting names, as I feel like it adds more wordiness than improved user comprehension

[PikachuEXE]

So just remove by Default label text change? Fine for me
Pending #5866 for merge conflict storm

[PikachuEXE]

Version based on #5866 actually already done and being used by myself
Just waiting for that to be merged before I push those changes...

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[PikachuEXE]

PR title, body, code updated to be based on #5866