Support taking video screenshots outside of Electron #6399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer,
kommunarr and
MarmadileManteater
github-actions
bot
added
the
PR: waiting for review
VirtualBoxVM_P2ZaLZe4CD.mp4
|
Get similar errors w/ multiple IV instances... |
|
Ah great, looks like just after I submitted this PR, all Invidious instances switched to blocking cross-origin requests: (CORS column on this page: https://api.invidious.io/). |
|
instance doesnt seem to work for me as im getting the same error |
|
If an Invidious instance is working, it's probably using iv-org/invidious#4985 which doesn't support proxying urls through the API so it will be almost impossible to test the web build at this time. I'll approve this since the electron build is working. Related: |
ChunkyProgrammer
approved these changes
Dec 19, 2024
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Dec 22, 2024
PikachuEXE
approved these changes
Dec 23, 2024
github-actions
bot
removed
the
PR: waiting for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support taking video screenshots outside of Electron
Pull Request Type
Description
At the moment taking video screenshots is a feature exclusive to the Electron build of FreeTube, which means that it is not usuable in the FreeTubeAndroid fork. This limitation is not so much an intentional limitation but more so because the existing implementation relied heavily on Node.js and Electron APIs.
This pull request add support for taking screenshots with prompting for the save location outside of Electron. I don't have access to a FreeTubeAndroid compatible device to test this but hopefully it should work, as it uses the same prompt and save function as the data export. Saving to a specific folder is not supported outside of Electron as writing files without prompting the user requires more power than the web APIs offer and would require changes to FreeTubeAndroid's Kotlin code to replicate what we do with the Electron and Node.js APIs.
Notable changes:
Saved screenshottoast no longer shows the file path where the image was saved.Testing
Test that taking screenshots with the prompt for save path setting enabled works in both Electron and in Firefox (or FreeTubeAndroid if you have a compatible devices).
Also test that I didn't break saving to the default folder in Electron.
Desktop