Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added buttons to hide hidden channels/text #6156

Merged
merged 16 commits into from
Dec 19, 2024
Merged

Added buttons to hide hidden channels/text #6156

merged 16 commits into from
Dec 19, 2024

Conversation

JL0000
Copy link
Contributor

@JL0000 JL0000 commented Nov 12, 2024 •
edited by efb4f5ff-1298-471a-8973-3d47447115dc
Loading

Added buttons to hide hidden channels/text

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

closes #5652

Description

  • Added toggle switches to hide/show the channels and text hidden by filters set by user
  • Grouped the toggles together with the filtering into a new section

Screenshots

Before
before
After
after

Testing

Settings persist after closing the application.

Desktop

  • OS: MacOs
  • OS Version: 15.1
  • FreeTube version: v0.22.0 Beta

Additional context

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Nov 12, 2024
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) November 12, 2024 23:53
auto-merge was automatically disabled November 13, 2024 00:25

Head branch was pushed to by a user without write access

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) November 13, 2024 00:25
@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

Errors when entering the settings page and using the toggles

VirtualBoxVM_civ1heeKvZ.mp4

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added PR: changes requested and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Nov 15, 2024
auto-merge was automatically disabled November 15, 2024 12:08

Head branch was pushed to by a user without write access

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) November 15, 2024 12:08
@JL0000
Copy link
Contributor Author

JL0000 commented Nov 15, 2024

Fixed it.

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added PR: waiting for review For PRs that are complete, tested, and ready for review and removed PR: changes requested labels Nov 15, 2024
@PikachuEXE
Copy link
Collaborator

I think the label reads a bit confusing to me
Show Hidden Channels at first I thought it was disabling hiding channels then I read Show Hidden Text.
I think it would be better to label them as something like "show all already entered list of channels/text" (Not sure what exact words to use)
Or move the controls below each text input field (though not the best position I guess) so users can relate that control to the list of videos/texts

@absidue absidue added PR: changes requested and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Nov 21, 2024
@JL0000
Copy link
Contributor Author

JL0000 commented Nov 21, 2024

What do you think about List Hidden Channels and List Hidden Words?

@PikachuEXE
Copy link
Collaborator

Show Stored/Saved Hidden Channels & Show Stored/Saved Hidden Keywords?
Weird to see List...

@JL0000
Copy link
Contributor Author

JL0000 commented Nov 22, 2024

Because I name this section Content Filter I think Show Channels Added to Content Filter and Show Keywords Added to Content Filter works well. If content filter is vague, then Show Stored Hidden Channels and Show Stored Hidden Keywords works well too.

@PikachuEXE
Copy link
Collaborator

Show Added Channels + Show Added Keywords?
Assuming they are under heading Content Filter

auto-merge was automatically disabled November 22, 2024 15:14

Head branch was pushed to by a user without write access

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) November 22, 2024 15:15
auto-merge was automatically disabled December 7, 2024 16:36

Head branch was pushed to by a user without write access

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) December 7, 2024 16:36
auto-merge was automatically disabled December 7, 2024 16:40

Head branch was pushed to by a user without write access

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) December 7, 2024 16:40
@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added PR: waiting for review For PRs that are complete, tested, and ready for review and removed PR: changes requested labels Dec 8, 2024
absidue
absidue reviewed Dec 8, 2024
View reviewed changes
src/renderer/components/ft-input-tags/ft-input-tags.vue Outdated
Comment on lines 29 to 34
:id="label"
type="checkbox"
:checked="showTags"
@change="toggleShowTags"
>
<label :for="label">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please find a way to make this id unique, as this component is shown on the page 3 times at the same time, so using the same ID for all of them will result in the wrong label getting referenced.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be unique since it's taking the label prop but it should probably be somewhat sanitized (ex: spaces removed)

auto-merge was automatically disabled December 9, 2024 14:16

Head branch was pushed to by a user without write access

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) December 9, 2024 14:16
@FreeTubeBot FreeTubeBot merged commit 0fcf1be into FreeTubeApp:development Dec 19, 2024
10 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Dec 19, 2024
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request Dec 21, 2024
@PikachuEXE
Merge branch 'development' into custom-builds/tmp
3fe78d0 
* development: (57 commits)
  Translated using Weblate (Ukrainian)
  Translated using Weblate (Serbian)
  Translated using Weblate (Hungarian)
  Translated using Weblate (Icelandic)
  Translated using Weblate (Estonian)
  Translated using Weblate (Czech)
  Translated using Weblate (French)
  add missing release builds (FreeTubeApp#6415)
  Translated using Weblate (Serbian)
  Translated using Weblate (German)
  Translated using Weblate (Italian)
  Translated using Weblate (Chinese (Traditional Han script))
  apply overflow menu text color change only to overflow menu (not to stats button) (FreeTubeApp#6406)
  Make a single IPC call for the navigation history (FreeTubeApp#6366)
  Added buttons to hide hidden channels/text (FreeTubeApp#6156)
  Translated using Weblate (Serbian)
  Translated using Weblate (Afrikaans)
  Translated using Weblate (Afrikaans)
  Translated using Weblate (Vietnamese)
  Translated using Weblate (Afrikaans)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kommunarr kommunarr kommunarr approved these changes

@ChunkyProgrammer ChunkyProgrammer ChunkyProgrammer approved these changes

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc approved these changes

@PikachuEXE PikachuEXE PikachuEXE approved these changes

@MarmadileManteater MarmadileManteater Awaiting requested review from MarmadileManteater

@absidue absidue Awaiting requested review from absidue

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]: "Hide Videos From Channels" List As Submenu
7 participants
@JL0000 @efb4f5ff-1298-471a-8973-3d47447115dc @PikachuEXE @kommunarr @absidue @ChunkyProgrammer @FreeTubeBot