Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IV: Display video tags in search results #5590

Conversation

ChunkyProgrammer
Copy link
Member

@ChunkyProgrammer ChunkyProgrammer commented Aug 20, 2024

IV: Display video tags in search results

Pull Request Type

  • Feature Implementation

Related issue

Implements changes from #5119 when using the invidious API

Screenshots

image
image

Testing

  • set api preference to Invidious
  • search "8K"
  • see some videos with 8k tag appear
  • search "4k" and enable "3d" filter
  • see videos with 3d tag, vr180 tag, 360vr tag

Desktop

  • OS: Linux Mint
  • OS Version: 22
  • FreeTube version: latest nightly

Additional Context

Dependent on iv-org/invidious#4863

@ChunkyProgrammer ChunkyProgrammer changed the title Display video tags for Invidious IV: Display video tags in search results Aug 20, 2024
@ChunkyProgrammer ChunkyProgrammer force-pushed the display-video-tags-for-invidious branch 2 times, most recently from 3bca0fb to ff6c0f3 Compare August 29, 2024 02:10
SamantazFox added a commit to iv-org/invidious that referenced this pull request Oct 8, 2024
This PR makes it possible to display badges in the search results for third
party Invidious applications (ex: FreeTube)

See also: FreeTubeApp/FreeTube#5590

No related issue
@ChunkyProgrammer ChunkyProgrammer marked this pull request as ready for review October 8, 2024 16:39
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) October 8, 2024 16:39
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Oct 8, 2024
static/locales/en-US.yaml Outdated Show resolved Hide resolved
Copy link
Collaborator

@PikachuEXE PikachuEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder why Local API has no such tags...

@absidue
Copy link
Member

absidue commented Oct 10, 2024

The local API has a few, it's just that until now nobody has needed all of them (pretty sure FreeTube is the first program to actually use them) so nobody added support for all the other ones in YouTube.js. Generally people don't spend time adding functionality to YouTube.js unless they actually need it.

@FreeTubeBot FreeTubeBot merged commit c02d647 into FreeTubeApp:development Oct 10, 2024
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants