-
Notifications
You must be signed in to change notification settings - Fork 850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Page bookmarks #5003
Open
kommunarr
wants to merge
37
commits into
FreeTubeApp:development
Choose a base branch
from
kommunarr:feat/add-page-bookmarking
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Page bookmarks #5003
Changes from all commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
920bf92
Implement page bookmarking modal & call, icon, & handling/calls
kommunarr 808cadb
Update search results with matching bookmarks
kommunarr a12c4ea
Fix bookmark search result styling and keyboard interactions
kommunarr a3057c6
Add 'Remove All Page Bookmarks' setting
kommunarr e60cd78
Improve default bookmark names for Playlist and Search Results routes
kommunarr c254875
Fix bookmark searching logic
kommunarr 871e330
Update bookmark icon color to use secondary colors when top nav is co…
kommunarr f7b8f1a
Add aria-roledescription for page bookmark search results
kommunarr 0572d33
Fix deletion call and disable bookmark icon while data is being loade…
kommunarr 88ec2a8
Fix bookmark search results when search suggestions are disabled
kommunarr 7896b7b
Modify bookmark result star icon opacity
kommunarr 392fa75
Implement changes to make work re-usable for saving generic search hi…
kommunarr 78d1b9c
Merge branch 'development' of github.com:FreeTubeApp/FreeTube into fe…
kommunarr 5ee7638
Merge branch 'development' of github.com:FreeTubeApp/FreeTube into fe…
kommunarr 709caef
Update styling of search results
kommunarr 50dc04b
Merge branch 'development' of github.com:FreeTubeApp/FreeTube into fe…
kommunarr 5597720
Merge branch 'development' of github.com:FreeTubeApp/FreeTube into fe…
kommunarr c075058
Merge branch 'development' of github.com:FreeTubeApp/FreeTube into fe…
kommunarr d9d8c9c
Merge branch 'development' of github.com:FreeTubeApp/FreeTube into fe…
kommunarr ede347a
Fix page bookmark removal function call to pass the route, not the fu…
kommunarr d6429d5
Merge branch 'development' of github.com:FreeTubeApp/FreeTube into fe…
kommunarr 7f6a4ad
Add search history sync logic
kommunarr 33d2d50
Have 'Cancel' button appear for already bookmarked page case
kommunarr 4736723
Update to show the proper page bookmark name upon deletion
kommunarr 039fce1
Delete page bookmarks to user playlists when those user playlists are…
kommunarr 85e46b5
Add icons corresponding to bookmarked page route
kommunarr a81a8b5
Prevent search results from wrapping across to multiple rows
kommunarr e5b5b43
Constrain visible ft-input results list length to 15
kommunarr 094b2c2
Add message when there are other page bookmarks with the same name
kommunarr b162507
Update playlist route icons
kommunarr 13ba73e
Merge branch 'development' of github.com:FreeTubeApp/FreeTube into fe…
kommunarr 3504424
Merge branch 'development' into feat/add-page-bookmarking
kommunarr abbd349
Merge branch 'development' of github.com:FreeTubeApp/FreeTube into fe…
kommunarr 2039016
Merge branch 'development' of github.com:FreeTubeApp/FreeTube into fe…
kommunarr 69ed872
Merge branch 'development' of github.com:FreeTubeApp/FreeTube into fe…
kommunarr a2914fa
Remove ' - FreeTube' portion of default titles
kommunarr e9b539f
Only enable page bookmarking on certain routes
kommunarr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably should rename all related code to page bookmark?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The intention is that we could have persistent keyword search history entry logic here in the future (see
Future PRs
in OP), and page bookmarks are a type of search history.