Address review comments

Fix padding issue with new icon in top bar, fix bug where Enter bypasses empty name restriction, adjust modal button styling, allow community posts to be bookmarked
FreeTubeApp · Dec 4, 2024 · 5ddfbcc · 5ddfbcc
1 parent 2941e15
commit 5ddfbcc
Show file tree

Hide file tree

Showing 5 changed files with 21 additions and 6 deletions.
diff --git a/src/renderer/components/page-bookmark-prompt/page-bookmark-prompt.css b/src/renderer/components/page-bookmark-prompt/page-bookmark-prompt.css
@@ -7,3 +7,8 @@
   max-inline-size: 600px;
   margin-inline: auto;
 }
+
+.actions-container {
+  justify-content: center;
+  column-gap: 10px;
+}
diff --git a/src/renderer/components/page-bookmark-prompt/page-bookmark-prompt.js b/src/renderer/components/page-bookmark-prompt/page-bookmark-prompt.js
@@ -63,6 +63,10 @@ export default defineComponent({
     },
 
     save: function () {
+      if (this.name === '') {
+        return
+      }
+
       const pageBookmark = {
         route: this.$router.currentRoute.fullPath,
         name: this.name,

diff --git a/src/renderer/components/page-bookmark-prompt/page-bookmark-prompt.vue b/src/renderer/components/page-bookmark-prompt/page-bookmark-prompt.vue
@@ -24,8 +24,8 @@
         <p>{{ duplicateNameMessage }}</p>
       </ft-flex-box>
     </div>
-    <div class="actions-container">
-      <ft-flex-box>
+    <div>
+      <ft-flex-box class="actions-container">
         <ft-button
           v-if="!isBookmarkBeingCreated"
           :label="$t('Page Bookmark.Remove Bookmark')"

diff --git a/src/renderer/components/top-nav/top-nav.js b/src/renderer/components/top-nav/top-nav.js
@@ -53,6 +53,7 @@ export default defineComponent({
         'Channel',
         'Watch',
         'Hashtag',
+        'Post',
         'Settings' // for linkable settings sections
       ],
       lastSuggestionQuery: ''

diff --git a/src/renderer/components/top-nav/top-nav.scss b/src/renderer/components/top-nav/top-nav.scss
@@ -23,7 +23,7 @@
 
   @media only screen and (width >= 1162px) {
     display: grid;
-    grid-template-columns: 1fr 720px 0.5fr 0.5fr;
+    grid-template-columns: 1fr 440px 0.5fr 0.5fr;
   }
 
   @include top-nav-is-colored {
@@ -124,9 +124,14 @@
   }
 }
 
-.pageBookmarkIcon.favorite {
-  @include top-nav-is-colored {
-    color: var(--accent-color);
+.pageBookmarkIcon {
+  inline-size: fit-content;
+  padding: 10px;
+
+  &.favorite {
+    @include top-nav-is-colored {
+      color: var(--accent-color);
+    }
   }
 }