-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate TF-M split-build #108
Open
gergkv
wants to merge
9
commits into
FreeRTOS:main
Choose a base branch
from
gergkv:dev/gerkov02/tfm-split-build
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TF-M is built in build.sh and the configuration parameters are passed for the build in an initial cache script. The TfmInitialCache.cmake is only added for the blinky application in this commit. After TF-M is built, the artifacts to be used during the NS build are exported in the api_ns folder. Signed-off-by: Gergely Kovacs <[email protected]>
Removed the previous toolchain dependency and the NS toolchain exported by TF-M is used instead. The cross compilation flags are set up by this toolchain file (e.g. -mcpu). The compilation options are set by FRI, these options are the previously used options from the removed toolchain and the options used in TF-M merged. Signed-off-by: Gergely Kovacs <[email protected]>
Blinky application with the seperately build TF-M and the new toolchain. The cmake files exported by TF-M set up the NS interface. The default TF-M signing is used and the resulting images are merged by FRI. Signed-off-by: Gergely Kovacs <[email protected]>
The application is built similarly to blinky. The update image generation is unchanged. The mbedtls config file needs the DOMAIN_NS check because S and NS clients are not separated. The minimal config is added for S clients. Signed-off-by: Gergely Kovacs <[email protected]>
Signed-off-by: Gergely Kovacs <[email protected]>
The TF-M toolchain adds a __ARM_ARCH_8_1M_MAIN__ define which caused a build error in arm_2d. It is fixed in the new release. Signed-off-by: Gergely Kovacs <[email protected]>
Signed-off-by: Gergely Kovacs <[email protected]>
Signed-off-by: Gergely Kovacs <[email protected]>
The image version using the following naming: major.minor.patch.build Patch actually is the image header's revision. Signed-off-by: Dávid Házi <[email protected]>
cookpate
approved these changes
Feb 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
kar-rahul-aws
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR integrates the TF-M split build feature. It contains the following changes:
build.sh
Test Steps
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.