Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code to resolve lcov issues and mocks failing on Mac #307

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

DakshitBabbar
Copy link
Member

Description

Issue1:
Mocked function calls jump to real implementation instead of mocks on mac
Solution:
Convert the symbols of the mocked implementation from weak to strong

Issue2:
lcov generating wrong coverage reports on mac
Solution:
Rectifying network buffer size to be of the appropriate value otherwise memset clears out more memory spaces than required which leads to reseting the line coverage counters.

Issue3:
log statements being taken as branches
Solution:
Removing the ternary operation to figure out if there is a '/' in front of the file name or not. This can be done as this feature is just for debugging purposes.

Issue4:
Some tests failing randomly on mac
Solution:
Initialise variables at places where necessary

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

aggarg
aggarg previously approved these changes Sep 16, 2024
@DakshitBabbar DakshitBabbar merged commit afe000c into FreeRTOS:main Sep 17, 2024
11 checks passed
@DakshitBabbar DakshitBabbar deleted the coverage branch September 19, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants