Update code to resolve lcov issues and mocks failing on Mac #307
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue1:
Mocked function calls jump to real implementation instead of mocks on mac
Solution:
Convert the symbols of the mocked implementation from weak to strong
Issue2:
lcov generating wrong coverage reports on mac
Solution:
Rectifying network buffer size to be of the appropriate value otherwise memset clears out more memory spaces than required which leads to reseting the line coverage counters.
Issue3:
log statements being taken as branches
Solution:
Removing the ternary operation to figure out if there is a '/' in front of the file name or not. This can be done as this feature is just for debugging purposes.
Issue4:
Some tests failing randomly on mac
Solution:
Initialise variables at places where necessary
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.