Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small Type and Qualifier Fixes #67

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Small Type and Qualifier Fixes #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13047d5
Add explicit cast to uint32_t
StefanBalt Apr 24, 2024
54dfc08
Add const qualifier to FF_IsNameCompliant() pointer argument
StefanBalt Apr 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ff_dir.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2884,9 +2884,9 @@ FF_Error_t FF_ExtendDirectory( FF_IOManager_t * pxIOManager,

/* *INDENT-OFF* */
#if ( ffconfigUNICODE_UTF16_SUPPORT != 0 )
BaseType_t FF_IsNameCompliant( FF_T_WCHAR * pcName )
BaseType_t FF_IsNameCompliant( const FF_T_WCHAR * pcName )
#else
BaseType_t FF_IsNameCompliant( char * pcName )
BaseType_t FF_IsNameCompliant( const char * pcName )
#endif
/* *INDENT-ON* */
{
Expand Down
4 changes: 2 additions & 2 deletions ff_fat.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -712,7 +712,7 @@ uint32_t FF_FindEndOfChain( FF_IOManager_t * pxIOManager,
{
/* Traverse FAT for (2^32-1) items/clusters,
* or until end-of-chain is encountered. */
ulFatEntry = FF_TraverseFAT( pxIOManager, ulStart, ( uint32_t ) ~0UL, &xError );
ulFatEntry = FF_TraverseFAT( pxIOManager, ulStart, ~( ( uint32_t ) 0U ), &xError );
}
else
{
Expand Down Expand Up @@ -1496,7 +1496,7 @@ uint32_t FF_CountFreeClusters( FF_IOManager_t * pxIOManager,
{
ulFreeClusters = FF_getLong( pxBuffer->pucBuffer, 488 );

if( ulFreeClusters != ~0ul )
if( ulFreeClusters != ~( ( uint32_t ) 0U ) )
{
xInfoKnown = pdTRUE;
}
Expand Down
4 changes: 2 additions & 2 deletions include/ff_dir.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,9 +177,9 @@ int8_t FF_PushEntry( FF_IOManager_t * pxIOManager,
* contains any legal characters only.
*/
#if ( ffconfigUNICODE_UTF16_SUPPORT != 0 )
BaseType_t FF_IsNameCompliant( FF_T_WCHAR * pcName );
BaseType_t FF_IsNameCompliant( const FF_T_WCHAR * pcName );
#else
BaseType_t FF_IsNameCompliant( char * pcName );
BaseType_t FF_IsNameCompliant( const char * pcName );
#endif

static portINLINE BaseType_t FF_isEndOfDir( const uint8_t * pucEntryBuffer )
Expand Down
Loading