Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the FF_MakeNameCompliant behavior #63

Merged
merged 16 commits into from
Feb 27, 2024
Merged

Change the FF_MakeNameCompliant behavior #63

merged 16 commits into from
Feb 27, 2024

Commits on Jan 31, 2024

  1. Change the FF_MakeNameCompliant behavior 

    Invalid path characters cause now an error.
(FF_ERR_FILE_INVALID_PATH if a file should be created
and FF_ERR_DIR_INVALID_PATH for directories)
    @togrue
    Tobias Gruen authored and togrue committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    065a9e4 View commit details
    Browse the repository at this point in the history

  2. Exclude the forbiddenChrs array from uncrustify

    @togrue
    togrue committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    61baf4e View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2024

  1. Merge branch 'main' into fix_invalid_path

    @togrue
    togrue authored Feb 1, 2024
    Configuration menu
    Copy the full SHA
    4000979 View commit details
    Browse the repository at this point in the history

  2. Cleanup indentation and improve consistency 

    Fixed the indentation.
And also removed the superfluous (== pdTrue) in the if condition.
    @togrue
    togrue committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    a7e51c1 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2024

  1. Move the happy path 

    The happy code path is now located in the else branch
which improves locality of the error handling.
    @togrue
    togrue committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    e0037f3 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2024

  1. Change MakeNameCompliant return type to BaseType_t

    @togrue
    togrue committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    066d9e7 View commit details
    Browse the repository at this point in the history

  2. Fix BaseType_t

    @togrue
    togrue committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    4d7e214 View commit details
    Browse the repository at this point in the history

  3. Rename chrs to chars

    @togrue
    togrue committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    59b1673 View commit details
    Browse the repository at this point in the history

  4. Fix misra compliance

    @togrue
    togrue committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    65f1137 View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2024

  1. Check the filenames earlier 

    These changes were made by hitibosch.

They move the name check upward in the call-hierarchy.
    @togrue
    togrue committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    d065004 View commit details
    Browse the repository at this point in the history

  2. Use the mkdir pcDirName for the filename check 

    The previously used pcPath contained slashes.
This lead to an error, because slashes are invalid Dir/Filename characters.
    @togrue
    togrue committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    2d1229c View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2024

  1. Rename function FF_MakeNameCompliant to FF_IsNameCompliant 

    The function does only perform checks now.
    @togrue
    togrue committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    01753aa View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2024

  1. Fix the IsNameCompliant check for FF_MOVE 

    This change was made by hitibosch.
I added just a comment.
    @togrue
    togrue committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    d44ee93 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2024

  1. Fix the filename handling in ff_Move 

    The first character of the destination filename was omitted
when a file in the root directory was supplied.

This change was made by hitibosch.
    @togrue
    togrue committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    4268c23 View commit details
    Browse the repository at this point in the history

  2. Fix missing initialization of xError in FF_Move 

    The error variable could get accessed before initialization.
    @togrue
    togrue committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    174fd46 View commit details
    Browse the repository at this point in the history

  3. Run code-formatter 

    Using uncrustify v 0.67
And the uncrustify config from the FreeRTOS main project.
    @togrue
    togrue committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    bebaaad View commit details
    Browse the repository at this point in the history