Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cmake configure for STM32F4XX and STM32F7XX #59

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Fix cmake configure for STM32F4XX and STM32F7XX #59

merged 1 commit into from
Dec 20, 2023

Conversation

safesintesi
Copy link
Contributor

Fixed bug that prevented STM32F4XX and STM32F7XX from correctly configure with cmake.

Description

Setting FREERTOS_PLUS_FAT_PORT to STM32F4XX would throw fatal error at line 57 of root CMakeLists.txt since not in FREERTOS_PLUS_FAT_PORT_LIST.
Setting FREERTOS_PLUS_FAT_PORT to STM32FXX as in the list of ports (notice no number before XX), would throw error since at portable/CMakeLists.txt:38 it would NOT mach with any generator and result in no sources for freertos_plus_fat_port target.

Test Steps

set FREERTOS_PLUS_FAT_PORT to either STM32F4XX or STM32F7XX

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Fixed bug that prevented STM32F4XX and STM32F7XX from correctly configure with cmake
@safesintesi safesintesi requested a review from a team as a code owner December 18, 2023 23:38
@bradleysmith23 bradleysmith23 requested review from bradleysmith23 and removed request for a team December 19, 2023 01:23
Copy link
Contributor

@htibosch htibosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@safesintesi , thank you for this PR.

CMakeLists.txt Show resolved Hide resolved
safesintesi added a commit to AlbaSat/OBC_STM32 that referenced this pull request Dec 19, 2023
Added targets for drivers and core
Fixed some libraries link
Defined STM32F411xE as default build in
Drivers/CMSIS/.../stm32f4xx.h

This now builds with cmake but needs a tweek on FAT repo
A pull request has been already made:
FreeRTOS/Lab-Project-FreeRTOS-FAT#59
@bradleysmith23 bradleysmith23 merged commit bc13a8a into FreeRTOS:main Dec 20, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants