Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI-CD-Updates #58

Merged
merged 18 commits into from
Dec 6, 2023
Merged

CI-CD-Updates #58

merged 18 commits into from
Dec 6, 2023

Conversation

Skptak
Copy link
Member

@Skptak Skptak commented Nov 28, 2023

Description

Adding basic CI-CD, spelling, and formatting checks
Converts all line endings to LF if they were CRLF
Removes trailing whitespace from non-binary files
I recommend reviewing this with a whitespace free diff of the changes, which can be seen here

Test Steps

CI-CD based build of the project

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Skptak Skptak requested a review from a team as a code owner November 28, 2023 03:18
@Skptak Skptak marked this pull request as draft November 28, 2023 03:18
@Skptak Skptak marked this pull request as ready for review November 28, 2023 17:07
@Skptak Skptak mentioned this pull request Nov 28, 2023
2 tasks
@Skptak
Copy link
Member Author

Skptak commented Nov 28, 2023

Formatting bot changes have been tested on a local PR to my fork, as seen here

Copy link
Contributor

@htibosch htibosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Skptak , thank you for this PR. At first I was shocked by the high number of changes, but when ignoring whitespace changes, typos remain, and there were quite a few.
You even caught a C misspelled identifier: s/FileFormatGrouop/FileFormatGroup/

@Skptak
Copy link
Member Author

Skptak commented Nov 30, 2023

@Skptak , thank you for this PR. At first I was shocked by the high number of changes, but when ignoring whitespace changes, typos remain, and there were quite a few. You even caught a C misspelled identifier: s/FileFormatGrouop/FileFormatGroup/

Haha yeah, the line count can make it daunting at first. I'm going to start providing a link to the whitespace free diff when doing these kinda PRs in the future. I've gone ahead and handled the merge conflict from merging in #56, would you mind double-checking that everything in here looks good?

@Skptak Skptak merged commit 90281cb into FreeRTOS:main Dec 6, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants