-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI-CD-Updates #58
CI-CD-Updates #58
Conversation
b273362
to
a833460
Compare
Formatting bot changes have been tested on a local PR to my fork, as seen here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Skptak , thank you for this PR. At first I was shocked by the high number of changes, but when ignoring whitespace changes, typos remain, and there were quite a few.
You even caught a C misspelled identifier: s/FileFormatGrouop/FileFormatGroup/
dccf299
to
61956b4
Compare
Haha yeah, the line count can make it daunting at first. I'm going to start providing a link to the whitespace free diff when doing these kinda PRs in the future. I've gone ahead and handled the merge conflict from merging in #56, would you mind double-checking that everything in here looks good? |
Description
Adding basic CI-CD, spelling, and formatting checks
Converts all line endings to LF if they were CRLF
Removes trailing whitespace from non-binary files
I recommend reviewing this with a whitespace free diff of the changes, which can be seen here
Test Steps
CI-CD based build of the project
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.