Small Type and Qualifier Fixes #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanBalt
changed the title
|
I also added a second commit where I add the const qualifiert to the FF_IsNameCompliant() argument. This fixes a -Wdiscarded-qualifiers warning. |
htibosch
approved these changes
Apr 24, 2024
There was a problem hiding this comment.
Thank you @StefanBalt for these changes. I guess it saves a couple of warnings.
I approve it if you can remove the ul suffix.
ff_fat.c
Outdated
| @@ -1496,7 +1496,7 @@ uint32_t FF_CountFreeClusters( FF_IOManager_t * pxIOManager, | |||
| { | |||
| ulFreeClusters = FF_getLong( pxBuffer->pucBuffer, 488 ); | |||
|
|
|||
| if( ulFreeClusters != ~0ul ) | |||
| if( ulFreeClusters != ( uint32_t ) ~0ul ) | |||
There was a problem hiding this comment.
I tend to avoid the use of the ambiguous 'ul' suffix and write the following:
- if( ulFreeClusters != ( uint32_t ) ~0ul )
+ if( ulFreeClusters != ~( ( uint32_t ) 0U ) )There was a problem hiding this comment.
the U suffix does not have any effect now but I guess it is FreeRTOS style
Otherwise the condition is always true for 64-bit architectures.
The argument is read-only.
moninom1
approved these changes
Apr 26, 2024
aggarg
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise the condition is always true for 64-bit architectures.
GCC warned me about this when compiling AARCH64 (-Wtype-limits).