-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Update download locations to outside repository content #1280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Gaurav Aggarwal <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1280 +/- ##
==========================================
- Coverage 91.59% 91.53% -0.06%
==========================================
Files 6 6
Lines 3259 3261 +2
Branches 902 904 +2
==========================================
Hits 2985 2985
Misses 132 132
- Partials 142 144 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks correct, would be nice to have a comment on the commit "why" or what you try to archive.
@@ -211,21 +224,23 @@ jobs: | |||
sudo apt install -y autogen gawk libgmp-dev libmpc-dev libmpfr-dev | |||
sudo apt install -y patchutils sharutils zlib1g-dev autoconf2.64 | |||
|
|||
pushd $HOME |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the purpose of pushd and popd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change the directory and the restore.
Description
This PR updates all download commands (such as wget) to download files outside the repository content.
Test Steps
NA
Checklist:
Related Issue
NA.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.