Skip to content

Update download locations to outside repository content #1280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jun 5, 2025

Conversation

kar-rahul-aws
Copy link
Member

@kar-rahul-aws kar-rahul-aws commented May 26, 2025

Description

This PR updates all download commands (such as wget) to download files outside the repository content.

Test Steps

NA

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

NA.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@kar-rahul-aws kar-rahul-aws requested a review from a team as a code owner May 26, 2025 07:31
@kar-rahul-aws kar-rahul-aws marked this pull request as draft May 26, 2025 07:31
@aggarg aggarg changed the title Update wget or curl commands to download files to directories inaccessible to PR authors. Update download locations to outside repository content May 26, 2025
@aggarg aggarg marked this pull request as ready for review June 2, 2025 07:19
aggarg
aggarg previously approved these changes Jun 2, 2025
@kar-rahul-aws kar-rahul-aws changed the title Update download locations to outside repository content [ DO NOT MERGE ]Update download locations to outside repository content Jun 2, 2025
Copy link

codecov bot commented Jun 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.53%. Comparing base (60f34f8) to head (a74129b).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1280      +/-   ##
==========================================
- Coverage   91.59%   91.53%   -0.06%     
==========================================
  Files           6        6              
  Lines        3259     3261       +2     
  Branches      902      904       +2     
==========================================
  Hits         2985     2985              
  Misses        132      132              
- Partials      142      144       +2     
Flag Coverage Δ
unittests 91.53% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

sonarqubecloud bot commented Jun 5, 2025

@aggarg aggarg changed the title [ DO NOT MERGE ]Update download locations to outside repository content Update download locations to outside repository content Jun 5, 2025
Copy link

@thomas-roos thomas-roos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct, would be nice to have a comment on the commit "why" or what you try to archive.

@@ -211,21 +224,23 @@ jobs:
sudo apt install -y autogen gawk libgmp-dev libmpc-dev libmpfr-dev
sudo apt install -y patchutils sharutils zlib1g-dev autoconf2.64

pushd $HOME

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the purpose of pushd and popd

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the directory and the restore.

@aggarg aggarg merged commit 62bd622 into FreeRTOS:main Jun 5, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants