Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rlm_totp and add new test suite #5201

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
+285 −8
Open

Fix rlm_totp and add new test suite #5201

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5ff6c6e
totp: Add tests validating rlm_totp
jpereira Sep 14, 2023
6fff68e
totp: Fix call_env setting
jpereira Oct 4, 2023
03a3715
totp: The fr_totp_cmp() expects 'user_password' value.
jpereira Oct 4, 2023
91fae75
totp: Fix methods set
jpereira Oct 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/modules/rlm_totp/rlm_totp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,8 @@ module_rlm_t rlm_totp = {
.instantiate = mod_instantiate
},
.method_names = (module_method_name_t[]){
{ .name1 = "authenticate", .name2 = CF_IDENT_ANY, .method = mod_authenticate, .method_env = &method_env },
{ .name1 = "authenticate", .name2 = CF_IDENT_ANY, .method = mod_authenticate, .method_env = &method_env },
{ .name1 = CF_IDENT_ANY, .name2 = CF_IDENT_ANY, .method = mod_authenticate, .method_env = &method_env },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not clear why this is necessary? The totp module really should only be authenticating users.

I guess that it could go anywhere to authenticate users, but we generally put the pap, chap, etc. authentications into an authenticate section

MODULE_NAME_TERMINATOR
}
};