Bug fixes for Windows and the OPC UA server

[Magnulas]

This pull request should fix the following issues:

• Some Windows specific build errors (ex. Definition doesn't match declaration in uri_facade_win.cpp/uri_facade.h #311)

• Issue Can't monitor large number variables in client, e.g. 1000 items #193 where large requests could not fit in the servers buffer.

• The issue described in the following closed pull request Changed AddDataChangeCallback to mirror python-opcua implementation #293 where clients were disconnected from the server when trying to monitor a non existing item.

[cenit]

Hi @Magnulas,
Thanks for your contributions. I did something similar in some parts to bring freeopcua to vcpkg: https://github.com/Microsoft/vcpkg/tree/master/ports/freeopcua
Since we aim for a very stable release, can I ask you if the other parts of your patches are still required? If you have time, would you mind try it and contribute the necessary patchset also there?

[Magnulas]

Hi @cenit,
I’ve looked at the patches you made and compared them to my own and I can’t see anything else that would be needed for building freeopcua for Windows. I tested building free opcua with vcpkg and VS2017, and I didn’t encounter any problems with freeopcua when linking it to my project.

I’m however running my opc ua server as a service, which is why I suggested using the linux version of uri_facade_*.cpp in the pull request, as it is compatible with Windows.

[cenit]

Ok, good to know that Linux version is compatible also with windows. Happy to know that you can use vcpkg port of freeopcua without any problem. Please let me know if you encounter any, and you are very welcome to do a PR also there just in case

[valeria2706]

Hi @cenit,
I’ve looked at the patches you made and compared them to my own and I can’t see anything else that would be needed for building freeopcua for Windows. I tested building free opcua with vcpkg and VS2017, and I didn’t encounter any problems with freeopcua when linking it to my project.

I’m however running my opc ua server as a service, which is why I suggested using the linux version of uri_facade_*.cpp in the pull request, as it is compatible with Windows.

Hi @Magnulas , I used the patch you provided and vcpkg however it does not work for me. I have these following errors while building example_server. Can you help me take a look? Can't appreciate it more.

[Magnulas]

Hi @valeria2706,

Try casting the doubles to unsigned longs using static_cast. That's what they're doing in the latest version of the master branch for freeopcua. For the commit I created this pull request for the doubles were note cast. I assume they require a cast with a later version of boost. So if you clone the latest version of the master branch and merge it with my changes it should work.