Short links #544
Merged
Short links #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmz
reviewed
Nov 17, 2021
davidmz
reviewed
Nov 17, 2021
davidmz
reviewed
Nov 17, 2021
davidmz
reviewed
Jan 12, 2022
clbn
force-pushed
the
short-links
branch
2 times, most recently
from
3eab565
to
6554ea0
Compare
davidmz
reviewed
Jan 19, 2022
davidmz
reviewed
Jan 19, 2022
davidmz
reviewed
Jan 19, 2022
clbn
force-pushed
the
short-links
branch
3 times, most recently
from
44358fc
to
ae6669e
Compare
clbn
force-pushed
the
short-links
branch
6 times, most recently
from
0468ed4
to
e497690
Compare
davidmz
reviewed
Jul 25, 2023
app/support/backlinks.ts
Outdated
| @@ -16,6 +16,11 @@ export function extractUUIDs(text: string | null): UUID[] { | |||
| return text ? [...text.matchAll(uuidRe)].map((m) => m[0]).filter(onlyUnique) : []; | |||
| } | |||
|
|
|||
| export const shortLinkRe = /\/[A-Za-z0-9]{3,25}\/([0-9a-f]{6,10})/gi; | |||
There was a problem hiding this comment.
Тут ещё надо минус учесть, для groupnames
There was a problem hiding this comment.
И не надо ли границу слов как-то проверять? А то оно и в посторонних урлах может сработать. Или понадеемся, что 6 символов с нашими id-ами вряд ли совпадут?
There was a problem hiding this comment.
Тут непонятно. С одной стороны, мы вроде как хотели всю эту логику на клиент отдать. С другой стороны, из-за бэклинков вот приходится делать парсинг на сервере. Надо бы как-то формализовать это, чтоб алгоритм на сервере и клиенте — ну, не совпадали, но хоть как-то были близки.
Или не париться, потому что к большому беспорядку false positives не приведут…
clbn
force-pushed
the
short-links
branch
2 times, most recently
from
63ca674
to
38aba98
Compare
davidmz
reviewed
Jul 26, 2023
davidmz
reviewed
Jul 26, 2023
davidmz
reviewed
Aug 8, 2023
clbn
force-pushed
the
short-links
branch
3 times, most recently
from
2f8ac64
to
abf46f7
Compare
We define short_comment_id as two characters of the UUID, followed by the hex-encoded seq_number.
This change adds parsing of short comment links (e.g. `/user/9bac13#ad2b`) to EventService a.k.a Notifications. That is the only place we need special support. Other relevant server parts (backlinks table, reindex script, realtime events) only need the post_id anyway (for now), so they work with such links already, not caring about the comment_id part.
Before: - generate shortId on READ - use 2 chars of UUID followed by seqNumber (resulting length is 3+) After: - generate shortId on WRITE, and put into table `comments` (column `short_id`) - use randomly generated hex string (resulting length is 4-6)
clbn
force-pushed
the
short-links
branch
2 times, most recently
from
38dc55d
to
ea7805b
Compare
davidmz
previously approved these changes
Aug 17, 2023
davidmz
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the server-side part of the Short Links feature.
shortIdprop to Post objects in API responsesGET /v2/posts/:postId) to accept post's short ID along with the long IDPart 2: