performance optimizations for big repos #1277
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… are too aggressive
1 task
Closed
campersau
reviewed
Feb 16, 2020
There was a problem hiding this comment.
The tests on travis are failing for the same reasons:
https://travis-ci.org/FredrikNoren/ungit/jobs/651035697#L1570
| } | ||
|
|
||
| setData(logEntry) { | ||
| this.title(logEntry.message.split('\n')[0]); | ||
| this.parents(logEntry.parents || []); | ||
| this.commitTime = logEntry.commitDate; | ||
| this.date = Date.parse(this.commitTime); | ||
| this.timestamp = logEntry.timestamp || Date.parse(this.commitTime); |
There was a problem hiding this comment.
Since the commitDate is already parsed on the server is the fallback here still required?
Suggested change
| this.timestamp = logEntry.timestamp || Date.parse(this.commitTime); | |
| this.timestamp = logEntry.timestamp; |
Co-Authored-By: campersau <[email protected]>
|
I think this can be closed, see #1461 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent full gitlog history from server to client and load only what is needed
Upon page load, client will make and API call to get list of git nodes. However, this call gets list of ALL nodes every time. i.e. if a pages is showing 300 nodes and user scrolls down asking for 25 more nodes, backend will return 325 nodes, not just the 25 nodes needed.
This is now fixed and backend will return only the nodes client needs.
Prevent redundant ref and node calculations per each /gitlog api call
One of the biggest performance hit for big repos was due to git refs calculations because ungit loads ALL
refs, local and remote branches and tags of it's history.
This is needed to some degree to display them in the branch drop down and etc, but there were some inefficiencies on logic that thinking these refs had valid nodes and did unnecessary calculations.