fix: Use CRLF #14
Merged
fix: Use CRLF #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frederick888
force-pushed
the
crlf
branch
2 times, most recently
from
76764c9 to
210a798
Compare
When editing PRs in GitHub web, PR bodies use CRLF. But since gh-cli doesn't convert body inputs from LF to CRLF, this can lead to mixed LF/CRLF. Ideally we identify what a PR currently uses (if it was submitted via CLI or web), but simply using CRLF across the board isn't too bad either. Most modern text editors can handle both anyway. [1] actions/runner#1462
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
a15970dfix: Use CRLFWhen editing PRs in GitHub web, PR bodies use CRLF. But since gh-cli
doesn't convert body inputs from LF to CRLF, this can lead to mixed
LF/CRLF.
Ideally we identify what a PR currently uses (if it was submitted via
CLI or web), but simply using CRLF across the board isn't too bad
either. Most modern text editors can handle both anyway.
[1] actions/runner#1462
Checklist
I have rebased my branch so that it has no conflicts
Commit messages are compliant with Conventional Commits
Is this a breaking change?
No