Fixes for PRs from public forks #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows running gh-ph using pull_request_target as the triggering event, which unlike the pull_request event, gives the GITHUB_TOKEN writer permissions so that gh-ph can update the PR. But when using pull_request_target, actions/checkout does not initialise the PR head. Here we simply use gh CLI instead.
This should allow gh-ph to run on PRs from public forks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
17b4944fix: Use gh pr checkout instead of relying on actions/checkoutThis allows running gh-ph using pull_request_target as the triggering
event, which unlike the pull_request event, gives the GITHUB_TOKEN
writer permissions so that gh-ph can update the PR.
But when using pull_request_target, actions/checkout does not initialise
the PR head. Here we simply use gh CLI instead.
f81c1f2docs: Suggest using pull_request_targetThis should allow gh-ph to run on PRs from public forks.
Checklist
Is this a breaking change?
No