Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add argumentEdges to ResolveCallExpressionAmbiguityPass #2041

Merged
merged 4 commits into from
Feb 11, 2025

Conversation

lshala
Copy link
Contributor

@lshala lshala commented Feb 11, 2025

The PR adds the argumentEdges when replacing a CallExpression to a ConstructExpression ensuring that the names are also adopted

Copy link
Contributor

@maximiliankaul maximiliankaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes an issue: LGTM. @oxisto do we need more fixes like this? Can we somehow prevent bugs like this in the future?

@lshala lshala changed the title Add argumentEdges to ResolveCallExpressionAmbiguityPass Add argumentEdges to ResolveCallExpressionAmbiguityPass Feb 11, 2025
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.26%. Comparing base (25c22cd) to head (43f04ce).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...c/cpg/passes/ResolveCallExpressionAmbiguityPass.kt 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
.../de/fraunhofer/aisec/cpg/helpers/SubgraphWalker.kt 82.60% <100.00%> (+0.33%) ⬆️
...c/cpg/passes/ResolveCallExpressionAmbiguityPass.kt 75.67% <80.00%> (-2.38%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lshala lshala marked this pull request as ready for review February 11, 2025 15:06
@lshala lshala merged commit 6140a2f into main Feb 11, 2025
4 checks passed
@lshala lshala deleted the ls/fix-argumentEdges-name branch February 11, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants