-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: Resolve import types for superclasses #2034
Conversation
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (72.22%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files
☔ View full report in Codecov by Sentry. |
Unfortunately, this change is causing errors in the |
70e18d4
to
6fe6aff
Compare
Where exactly? Do you have a test file? |
I tried to parse the |
There seems to be a confusion in https://github.com/openstack/cinder/blob/a1fb7da213b72040b8c3fa2b2708f23c21da20b2/cinder/api/urlmap.py#L168 the super declaration is the same as the declaration after resolving. Which is weird because the record is |
A good fix for that seems to be (partially) blocked by #2020 |
6b25f96
to
f667a0d
Compare
f667a0d
to
71656ee
Compare
8380b24
to
e588a24
Compare
71656ee
to
db7d529
Compare
03a114d
to
1de14ed
Compare
db7d529
to
7dd8790
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
...ge-python/src/main/kotlin/de/fraunhofer/aisec/cpg/frontends/python/PythonLanguageFrontend.kt
Outdated
Show resolved
Hide resolved
982872f
to
7c8dd00
Compare
This PR adds the handling for nested
AST.Attribute
s, ensuring that superclass imports are correctly resolved