Handle InitializerListExpressions as variables of ComprehensionExpressions in the DFG
#2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssions in the DFG
KuechA
requested review from
maximiliankaul,
lshala,
konradweiss and
oxisto
as code owners
oxisto
reviewed
Feb 11, 2025
| @@ -149,3 +149,11 @@ interface HasOverloadedOperation : HasOperatorCode { | |||
| */ | |||
| val operatorBase: Expression | |||
| } | |||
|
|
|||
| interface HasAccess { | |||
There was a problem hiding this comment.
add a small doc string for the interface itself please.
| @@ -47,7 +46,7 @@ class ForEachStatement : LoopStatement(), BranchingNode, StatementHolder { | |||
| astOptionalEdgeOf<Statement>( | |||
| onChanged = { _, new -> | |||
| val end = new?.end | |||
| if (end is Reference) { | |||
| if (end is HasAccess) { | |||
There was a problem hiding this comment.
Could be written as (end as? HasAccess)?.access = .... to be consistent with the other assignments.
| @@ -72,9 +72,9 @@ class AssignExpression : | |||
| } | |||
|
|
|||
| if (isSimpleAssignment) { | |||
There was a problem hiding this comment.
Could be written as
(end as? HasAccess)?.access = if(isSimpleAssignment) {
AccessValues.WRITE
} else {
AccessValues.READWRITE
}| @@ -43,7 +44,7 @@ class ComprehensionExpression : Expression(), ArgumentHolder { | |||
| of = ProblemExpression("Missing variableEdge in ${this::class}"), | |||
| onChanged = { _, new -> | |||
| val end = new?.end | |||
| if (end is Reference) { | |||
| if (end is HasAccess) { | |||
There was a problem hiding this comment.
(it.end as? HasAccess)?.access to be consistent
| * Is this reference used for writing data instead of just reading it? Determines dataflow | ||
| * direction | ||
| */ | ||
| var access: AccessValues |
There was a problem hiding this comment.
On second thought. Wouldn't it make sense to just implements this on all Expression nodes? The memory overhead is probably negligible and we would remove a lot of ugly as? HasAccess casts. Basically this should apply to all expressions.
| } | ||
| } | ||
|
|
||
| // state.push(writtenToIt, PowersetLattice(identitySetOf(currentNode.iterable))) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapts the
ControlFlowSensitiveDFGPassto handle multiple declarations and references in the variable ofComprehensionExpressions. To enhance the readability, the logic is moved to an own function.Fixes #1957, #2017
It further introduces a new interface
HasAccessfor Nodes which can be read from or written to. This allows to set the attributeaccess: AccessValuesfor more nodes thanReferenceand it also allows to implement a propagation logic per node class. Currently, the classesReference,InitializerListExpressionandSubscriptExpressionimplement this interface. It is mainly used to determine the direction of DFG edges.