Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[in progress] Gormv2 #958

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

[in progress] Gormv2 #958

wants to merge 6 commits into from

Conversation

GeoffreyHuck
Copy link
Contributor

@GeoffreyHuck GeoffreyHuck commented May 9, 2023

We should upgrade to the latest version of GORM mainly for:

  • Being able to use complex nested OR (eg. A OR (B AND C)). Currently we need to use subqueries, which is bad for read/write and for performance
  • Being able to use addSelect(), which makes it possible to simplify the construction of complex queries
  • Being able to follow the future updates

General:

  • update to latest GORM and make it compile
  • Rebased from 09/05/2023
  • fix swagger doc

Integration tests:

  • api/answers
  • api/contests (5 tests to fix; looks like 2 different issues)
  • api/groups/get_granted_permissions.feature (SQL syntax error)
  • api/groups/get_group_progress.feature (SQL syntax error)
  • api/groups/get_group_progress_csv.feature:305 (SQL syntax error)
  • api/groups/get_navigation.feature (Problem with new GORM interfaces)
  • api/groups/get_participant_progress.feature (Need to convert query with new With() methods)
  • api/groups/get_roots.feature (Problem with new GORM interfaces)
  • api/groups/get_team_progress.feature (SQL syntax error)
  • api/groups/get_team_progress_csv.feature (SQL syntax error)
  • api/groups/get_user_progress.feature (SQL syntax error)
  • api/groups/get_user_progress_csv.feature (SQL syntax error)
  • api/items (crashes during execution; should require at least the same amount of work than for api/groups; probably more)
  • api/threads
  • api/users

Unit tests:

  • api/groups/TestService_changeCode_RetriesOnDuplicateEntryError
  • database/TestDB_inTransaction_ErrorOnRollback
  • database/TestDB_inTransaction_RetriesOnDeadLockError
  • database/TestDB_inTransaction_RetriesOnDeadLockErrorAndPanicsOnRollbackError
  • database/TestGroupGroupStore_CreateRelation (query requires update)
  • logging/TestNewDBLogger_ErrorFallback (problem when testing a type)
  • service/TestBase_ResolveWatchedGroupID (problem with mocking)
  • service/TestApplySorting

Unknown:

  • The Unknown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants