Move ancestors recalculation back into initiating transactions + more granular locking during ancestors recalculation #1195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a8656c3.
This reverts commit df60342.
…by step transaction." This reverts commit 073cb2a.
…e transaction of CreateRelation." This reverts commit da99786.
…transaction, we need to close the transaction that was made just for the propagation before we do another operation." This reverts commit 8c3dda5.
…ransaction and fails. Let's see if we really have failed tests when doing this." This reverts commit 2a94144.
…ups propagations." This reverts commit 351e58e.
This reverts commit 54f4bbf.
…agation, because we want to split it into multiple transactions." This reverts commit d7e1b30.
…hronously." This reverts commit 16ce6f3.
…cestors and permissions are now scheduled instead of being done in the current transaction." This reverts commit 2cc9273.
…ion) "`createItem` and `updateItem`: schedule the items ancestors propagation instead of doing it in the flow." This reverts commit 06e4b65.
…torsPropagation() in the code
… we do not split them into separatate transactions anymore
…oncurrent sessions to read from groups_groups/items_items,groups/items during the ancestors recalculation
…Store.createNewAncestors()
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1195 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 237 237
Lines 14675 14660 -15
=========================================
- Hits 14675 14660 -15 ☔ View full report in Codecov by Sentry. |
smadbe
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the first step of #1181, here we make items/groups propagations always synchronous and move them back into initiating transactions.