Make inviting_user in invitationsView nullable #1124
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The situation where inviting_user (group_membership_changes.initiator_id) is null even for pending invitations having a corresponding (latest, with action='invitation_created') group membership change is possible and real. Actually, it's what we have in our dev database (and possibly the prod database too).
Because of 'ON DELETE SET NULL' in
new group_membership_changes rows having action='invitation_created' and initiator_id=NULL can be created from time to time.
Also, there are pending invitations that don't have corresponding (latest, with action='invitation_created') group membership changes (see #1123).
Here, in this PR, we address both situations. Also, when there is no corresponding group membership change, we use 'at' field from group_pending_requests instead of one from group_membership_changes.
Depends on #1122