Provide a better list of UK counties #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides a "better" list of UK counties, overriding the built in UK subdivisions repo which contained a mix of counties, London boroughs, and towns.
Although a county is not actually required for UK addresses (the postal service ignores it) it is normal in the UK to write addresses with a county.
With that said, UK counties are a minefield so we should not make the field required but simply provide it as an option with a reasonable list of county name
Sets the label in the CP for the Administrative Area field to "County" for UK addresses. This change is not reflected on the front end because we are hardcoding the address form rather than using values from the Address field layout and will be addressed in another PR.