Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payment step functionality and order confirmation page #16

Merged
merged 6 commits into from
Aug 21, 2024

Conversation

peteeveleigh
Copy link
Contributor

Payment step

This currently only works properly with a single payment gateway. I've set it up to use Stripe in my testing. We will need to revisit it at a later date. There are difficulties in having multiple gateways within the same form and I couldn't get the Stripe scripts to initialise when they were within the accordion.

I've had to move the payment submission button to within the main area as Stripe injects this and I could not find a way to submit their payment form from an external button.

I've taken the liberty of moving the billing address section above the card payment section. It just seemed to make more sense that way, especially with the payment button within the main area.

I've had issues setting the billing address if it's different to the shipping address. I think I have resolved these. However the billing address form is currently being populated with address values and it should probably be blank if it hasn't previously been set.

Updating an address submits to a different controller than the payment itself. So I've added submit buttons to the "Different billing address" form to get around this.

Order confirmation page

All information on this screen is generated from the order

There is, as far as I know, any means to handle the "Review or Cancel Your Order" thing without writing some custom code. I've taken the step of hooking the button up to point at a non-existent controller action for now.

Additional things

Though the shipping estimator is not working yet. I've changed the cart/order summary so that, once a shipping address is set, the wording changes to "Shipping" rather than "Estimated Shipping"

@peteeveleigh peteeveleigh merged commit ddfedcf into develop Aug 21, 2024
2 of 3 checks passed
@sjcallender sjcallender deleted the payment-step-functionality branch October 11, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant