Fixes toggling v-show fails with icon and layers text #315
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #313
v-show
didn't work when used directly on<font-awesome-icon>
after the reactivity change.It did work when it was wrapped in another element like a div or as a root element in a wrapper component.
I changed the icon and layers text so that the returned value is wrapped in
h()
which I suspect is the same thing that happens when it's the root element of a wrapper component.I couldn't find a way to test it automatically. I tried
compileAndMount
withv-show
but it didn't fail. Could be that the problem was introduced somewhere between Vue 3.0.0 and 3.0.11 but the current test utils version doesn't work with 3.0.11. I did test it manually and togglingv-show
no longer failed.