Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to get ready release 3.x #243

Merged
merged 14 commits into from
Feb 8, 2025
Merged

Fixes to get ready release 3.x #243

merged 14 commits into from
Feb 8, 2025

Conversation

mkszepp
Copy link
Collaborator

@mkszepp mkszepp commented Feb 5, 2025

Some minimal adjustments for next version

@mkszepp
Copy link
Collaborator Author

mkszepp commented Feb 5, 2025

I will try to find later some time to fix some points in readme... i have seen that some links are not correctly linked right now or are ending in an 404 (for example upgrade.md is missing...).
In additional i will try to upgrade one of my app to version v3.x before we do 3.x release.

@robmadole
Copy link
Member

Thanks for fixing the link I missed!

@mkszepp
Copy link
Collaborator Author

mkszepp commented Feb 8, 2025

@robmadole the typing is right now incorrect for parse.icon. In my convert i did think, that it was a mistake inside this project, but now i have detected that the addon wasn't working correctly.

I have seen that this issue was already reported ~ a year ago FortAwesome/Font-Awesome#20231
It would be good to fix this, so we can remove in any future the @ts-expect-error rule in this project

Possible fix for this bug see FortAwesome/Font-Awesome#20557

fyi: i have added a test for non default prefix now... so we will never run again into this bug

@mkszepp mkszepp merged commit 6395159 into 3.x Feb 8, 2025
16 checks passed
@mkszepp mkszepp deleted the fixes-for-release-3-x branch February 8, 2025 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants