Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DEVELOPMENT, CHANGELOG, fix github ci script & remove unnecessary export #242

Merged
merged 9 commits into from
Feb 5, 2025

Conversation

mkszepp
Copy link
Collaborator

@mkszepp mkszepp commented Feb 4, 2025

As discussed in #241 some fixes for releasing the addon.

In additional i have update the changelogs

@mkszepp
Copy link
Collaborator Author

mkszepp commented Feb 4, 2025

@robmadole i have reverted the package.json changes from here.
a23aa80#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519

This were not correctly... the changes which you did added here, are in ember-fontawesome folder already done.
The package.json outside is private and we do never deploy

@robmadole
Copy link
Member

Oh! I see @mkszepp. This is my first time with pnpm and releasing packages. Glad you're here to catch my missteps. 😁 Thank you.

@robmadole robmadole self-requested a review February 4, 2025 17:57
@mkszepp mkszepp changed the title Update DEVELOPMENT, CHANGELOG & remove unnecessary export Update DEVELOPMENT, CHANGELOG, fix github ci script & remove unnecessary export Feb 5, 2025
@mkszepp mkszepp merged commit 547cbef into FortAwesome:3.x Feb 5, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants