Add option to prevent firing multiple directions #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vietnogi Thank you for this! This is awesome and something i've also noticed before. I think this will be a great addition and possibly even be on by default, what are your thoughts? I have it added to the v7 project! Do you think you'd be able to add a test? |
|
❓ maybe off by default and change name more to its intent like
If it were the opposite and on by default:
|
hartzis
requested changes
Feb 21, 2022
| @@ -140,7 +143,12 @@ function getHandlers( | |||
| ? props.delta | |||
| : props.delta[dir.toLowerCase() as Lowercase<SwipeDirections>] || | |||
| defaultProps.delta; | |||
| if (absX < delta && absY < delta && !state.swiping) return state; | |||
| if (absX < delta && absY < delta && !state.swiping) | |||
| return { ...state, initialDirection: state.initialDirection || dir }; | |||
There was a problem hiding this comment.
🤔 i think we'd need to actually set initialDirection outside of the catch for delta. We should probably only count the initial direction once the user has surpassed the delta which signifies the start of a "swipe" or "swiping"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
User is swiping up but also to the right and firing events for swiping right causing unintentional functionality.
Use Case
User is scrolling up a list but its not straight so causing UX for swiping right.
Solution
Add add an option to prevent mix directions during a single swipe. A state for the initial direction is set and will be use to compare subsequent swipe movements. If the option is set and if the swipe direction changes, then we do not fire the event.
Before Example
After Example
