Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ama rules to use one source of truth for package builds #291

Merged
merged 4 commits into from
Jan 7, 2025

Conversation

JDMathew
Copy link
Collaborator

@JDMathew JDMathew commented Dec 19, 2024

Description

Previously ama.rules were either in both dist or src folders once the package was built. This worked fine but there was not one source of truth when devs were copying over the file in a monorepo setup. This change fixes rules to be contained to one place at the root of the package with the package.json file.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist: (Feel free to delete this section upon completion)

  • I have included a changeset if this change will require a version change to one of the packages.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have run all builds, tests, and linting and all checks pass
  • I have added tests that prove my fix is effective or that my feature works
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@JDMathew JDMathew self-assigned this Dec 19, 2024
Copy link

vercel bot commented Dec 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-ama ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 7, 2025 8:56pm

@JDMathew JDMathew force-pushed the task/one-source-of-rules branch from 5b56df7 to dc45c32 Compare January 7, 2025 20:56
@JDMathew JDMathew merged commit 460e339 into main Jan 7, 2025
3 checks passed
@JDMathew JDMathew deleted the task/one-source-of-rules branch January 7, 2025 21:01
@JDMathew
Copy link
Collaborator Author

JDMathew commented Jan 7, 2025

This change should simplify things for consumers working with mono-repos

@github-actions github-actions bot mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants