Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update useFocus Hook to handle animations and catch findNodeHandle errors #220

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

JDMathew
Copy link
Collaborator

Description

There are certain cases where findNodeHandle may throw an error. We now catch this and log it when in dev mode instead of crashing the app.

The focus hook has also been updated to handle on screen loads better where in certain cases it would not focus an element. setTimeout has been added to catch more of these cases.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist: (Feel free to delete this section upon completion)

  • I have included a changeset if this change will require a version change to one of the packages.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have run all builds, tests, and linting and all checks pass
  • I have added tests that prove my fix is effective or that my feature works
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@JDMathew JDMathew requested a review from ceceppa July 30, 2024 07:30
@JDMathew JDMathew self-assigned this Jul 30, 2024
Copy link

vercel bot commented Jul 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-ama ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 30, 2024 7:30am

@JDMathew JDMathew merged commit 018549a into main Jul 30, 2024
3 checks passed
@JDMathew JDMathew deleted the update-useFocus-hook branch July 30, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants