Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AMA documentation #219

Merged
merged 7 commits into from
Jul 29, 2024
Merged

Fix AMA documentation #219

merged 7 commits into from
Jul 29, 2024

Conversation

ceceppa
Copy link
Member

@ceceppa ceceppa commented Jul 26, 2024 •
edited
Loading

Description

  • Fix accessibility issue on some color contrast
  • Adds "AMA Section" for mobile / tablet devices
Screenshot 2024-07-26 at 15 51 20
  • Excludes "index.md" from the custom autogenerated sidebar
  • Remove test code in the docusaurus config

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

@vercel Vercel
Copy link

vercel bot commented Jul 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-ama ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2024 8:24am

JDMathew
JDMathew approved these changes Jul 29, 2024
View reviewed changes
Copy link
Collaborator

@JDMathew JDMathew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just change className prop on <AMASidebar />

website/src/theme/DocItem/TOC/Desktop/index.js Outdated Show resolved Hide resolved
@ceceppa ceceppa marked this pull request as ready for review July 29, 2024 08:24
@ceceppa ceceppa merged commit 545d60b into main Jul 29, 2024
3 checks passed
@ceceppa ceceppa deleted the fix-documentation-style branch July 29, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JDMathew JDMathew JDMathew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ceceppa @JDMathew