Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ScrollView optional #218

Merged
merged 9 commits into from
Jul 29, 2024
Merged

Conversation

ceceppa
Copy link
Member

@ceceppa ceceppa commented Jul 26, 2024

Description

Allows not wrapping BottomSheet children inside a ScrollView. This allows the dev to have a different type of scrollable container, like FlatList, etc.

Fixes #210

Type of Change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Checklist: (Feel free to delete this section upon completion)

  • I have included a changeset if this change will require a version change to one of the packages.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have run all builds, tests, and linting and all checks pass
  • I have added tests that prove my fix is effective or that my feature works
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link

vercel bot commented Jul 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-ama ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2024 9:27am

@ceceppa ceceppa marked this pull request as ready for review July 29, 2024 09:27
Copy link
Collaborator

@JDMathew JDMathew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JDMathew JDMathew merged commit 943db65 into main Jul 29, 2024
3 checks passed
@JDMathew JDMathew deleted the bottomsheet-make-scrollview-optional branch July 29, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make ScrollView in BottomSheet optional
2 participants