fix: only add tabIndex when keyboardControls enabled (#984)

* fix: only add tabIndex when keyboardControls enabled * fix: tabIndex changes from review; changeset info
FormidableLabs · Nov 15, 2022 · 0ba2520 · 0ba2520 · vercel · Nov 15, 2022
1 parent 43da1cd
commit 0ba2520
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.changeset/few-dodos-watch.md b/.changeset/few-dodos-watch.md
@@ -0,0 +1,5 @@
+---
+'nuka-carousel': patch
+---
+
+slider-frame is no longer a focus target if enableKeyboardControls is false
diff --git a/packages/nuka/src/carousel.tsx b/packages/nuka/src/carousel.tsx
@@ -646,7 +646,7 @@ export const Carousel = (rawProps: CarouselProps): React.ReactElement => {
         }}
         aria-label={frameAriaLabel}
         role="region"
-        tabIndex={0}
+        tabIndex={enableKeyboardControls ? 0 : -1}
         onKeyDown={enableKeyboardControls ? onKeyDown : undefined}
         ref={carouselRef}
         onMouseUp={onMouseUp}