Feature/app router #213
Feature/app router #213
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
packages/nextjs/app/about/page.tsx
Outdated
There was a problem hiding this comment.
From migration guide -- create basic routes and put old pages as client components
There was a problem hiding this comment.
from migration guide -- old pages are now client side components. Future work entails moving client components to leaf nodes of component tree
packages/nextjs/middleware.ts
Outdated
There was a problem hiding this comment.
setCacheHeader was called in serverSideProps [example] but you can no longer do that. Based on this discussion, I've opted for middleware.
🖐️ I need help verifying this will still work with Fastly
| @@ -19,7 +19,7 @@ jobs: | |||
| - uses: actions/checkout@v2 | |||
| - uses: actions/setup-node@v2 | |||
| with: | |||
| node-version: 16.x | |||
| node-version: 18.x | |||
There was a problem hiding this comment.
Bumped node version as part of these changes here + in our vercel env
There was a problem hiding this comment.
(as mentioned in DMs) Do we have tests that use MSW? Can we get MSW to work with Next 14 / App Router?
There was a problem hiding this comment.
mswjs/msw#1644 and vercel/next.js#56446 are in ongoing discussions, so this does not currently work 😢
There was a problem hiding this comment.
I think we should move forward without fixing it. It’s a good cautionary tale about moving to AppRouter. And it will provide a good challenge in the future, once MSW/Next fixes compatibility.
What
Move to app router
Why
Latest and greatest!
Resources
Migration guide from Vercel team: https://nextjs.org/docs/app/building-your-application/upgrading/app-router-migration
Testing
Need to validate Fastly cache didn't break
Future work
next/imageuse client;to leaf nodes