Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V3 Release #89

Merged
merged 7 commits into from
May 14, 2024
Merged

V3 Release #89

merged 7 commits into from
May 14, 2024

Conversation

ryansrofe
Copy link
Collaborator

@ryansrofe ryansrofe commented May 9, 2024

Description

Release updates for V3

  • docs, readme, etc
  • minor update for button text

#74, #75, #54

How Has This Been Tested?

Tested in Figma in development and beta widgets.

ryansrofe added 2 commits May 9, 2024 14:54
to stay consistent with "log types" and log branding I updated the two buttons to say save log and delete log. Also added a quick check if there are no saved edits to not show the cancel button. This helps reenforce the new required behavior of saving each log.
@ryansrofe ryansrofe requested a review from cpresler May 9, 2024 19:03
@ryansrofe ryansrofe self-assigned this May 9, 2024
@ryansrofe ryansrofe added documentation Improvements or additions to documentation chore Chore and admin type task labels May 9, 2024
@ryansrofe ryansrofe added this to the Version 3 milestone May 9, 2024
Copy link
Contributor

@cpresler cpresler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

if user enters some text for a changelog and then wants to delete it, they can't. This is fixed.

users were allowed to add more than 8 links. This revealed a larger issue in terms of where links were being moved and referenced. Should be fixed now. Testing with the beta widget now.
@ryansrofe ryansrofe requested a review from cpresler May 13, 2024 20:34
@ryansrofe
Copy link
Collaborator Author

While prepping this branch for release, two bugs were discovered.

  1. Users could not delete content from an update, leaving the field blank. The previous content would reappear. This is fixed.
  2. Users could add more than 8 links after the edit flow switch. This has been fixed and users can only add a total of 8 links between saved and unsaved. There are now two lists, one for saved and one for unsaved and when deleting the correct link to removed.

Copy link
Contributor

@cpresler cpresler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

ryansrofe added 2 commits May 14, 2024 08:59
was getting errors when upgrading from earlier version 2 widgets where the users change would be erased, this has fixed. Also added a version number to the footer to make understanding what version of widget we are using easier.
@ryansrofe
Copy link
Collaborator Author

Updated for that pesky update bug that was deleting changes from users who were upgrading from previous versions like v2. Also added a version number to the footer so we can understand better which version of the widget we are using. I had a suspicion that I was seeing older versions of the widget when testing the publishing beta version. This helps. Going to release version 3.

@ryansrofe ryansrofe merged commit 390685e into main May 14, 2024
1 check passed
@ryansrofe ryansrofe deleted the fl74-v3-beta branch May 14, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chore and admin type task documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants