current update is saved when new log is created #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a user creates a log without saving and then tries to create a new log, the first log will be cleared. This update fixes that issue by bringing back the stored values in updates. If a user cancels their update the changes will not be committed.
cpresler
reviewed
Apr 18, 2024
| : changeLog.createdDate, | ||
| 'date', | ||
| ), | ||
| er: false, |
There was a problem hiding this comment.
should we be doing a check against changeLog.state?.updates?.createdDateTmp?.date?.er? It's edge case, but if a user exits editing while they have an error in the date we wouldn't want to erase that when they return - the validation logic only runs onTextEditEnd for the input.
^ This would apply to both date and time error values
There was a problem hiding this comment.
input fields have been refactored to include optional error messaging. The date and time fields are fully being tracked for errors etc for users and are kept in place if they navigate to another log and come back.
| key: changeLog.state?.updates?.link?.key ? changeLog.state?.updates?.link?.key : '', | ||
| }, | ||
| type: changeLog.state?.updates?.type ? changeLog.state?.updates?.type : changeLog.type, | ||
| change: changeLog.state?.updates?.change ? changeLog.state?.updates?.change : changeLog.change, | ||
| linkFormError: { label: false, url: false }, |
There was a problem hiding this comment.
similar to my other comment, I think we should be checking for error values here as well.
There was a problem hiding this comment.
input fields have been refactored to include optional error messaging. The link fields are fully being tracked for errors etc for users and are kept in place if they navigate to another log and come back.
Added a new value for GAP, this required an adjustment of the other GAP values to accommodate for the new GAP.lg value. The number values should be the same, the reference is just updated.
Added a new value for GAP, this required an adjustment of the other GAP values to accommodate for the new GAP.lg value. The number values should be the same, the reference is just updated. The vertical padding has also been removed. The new GAP.lg value makes this padding not needed.
Added a new value for GAP, this required an adjustment of the other GAP values to accommodate for the new GAP.lg value. The number values should be the same, the reference is just updated. The vertical padding has also been removed for last row. The new GAP.lg value makes this last row padding not needed. The radius tweak rounds the corners when avatars are hidden and squares off the top when shown to make it flush with the circle.
padding adjustments and new error messaging. The date error text was breaking out of the widget bounds when avatars and log types are off. All errors messages have been condensed in this consistent format.
- padding and spacing adjustments to take advantage of new GAP.lg option - updated error handling for links. When there is an error for label or URL the save change button will now toggle to error state consistent with date and time errors. - handling of dates and times (both error and valid) if a user switches to another log before saving. - bug fix when user enters update text and then removes it the previous text reappears. This no longer happens and users can add, remove etc without issue and this field is the only optional field. - added autolayout names as needed
very small adjustment to make dividers have rounded corners. All dividers, lines, and dashed lines should be rounded. The only place dashes are not rounded is the log type button. This will require a bit of refactor that isn't as easy to just get in line like the rest. I switched out the Rectangle for a Line because of how the dashes work.
changes the border for the left side to the darker grey when the row is actively focused and being edited. Provides a bit of a focus state when there are many rows. Also updated corner radius for the divider to make style guide.
The way in which errors are presented to the user was refactored and this function is not needed. Padding token was adjusted in a previous commit and is being removed here.
👆 Error in our tests Updated the typings file as suggested here --> https://www.figma.com/plugin-docs/api/typings/ Did the same for widget typings.
switching out tokens cleaning up tokens removing inline formulas using tokens fixing change type list key bug
refactored all log input fields into a new component
date and time fields main log update field link label and URL fields
is there a reason we are limiting the number of links to 8?
|
Quite a few updates to finish out this PR. Four sets of changes:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a user creates a log without saving and then tries to create a new log, the first log will be cleared. This update fixes that issue by bringing back the stored values in updates. If a user cancels their update the changes will not be committed.
Fixes # (issue)
Type of Change
How Has This Been Tested?
Tested locally in Figma.